CoinAlpha / gateway-api

Apache License 2.0
47 stars 25 forks source link

Test/add test script for uniswap v3 #127

Closed vic-en closed 3 years ago

PtrckM commented 3 years ago

uniswap v2

uniswap v3

tried DAI-USDC

Checking mid price for USDC-DAI on the MEDIUM fee tier...
/eth/uniswap/v3/price - Error: Request failed with status code 500
(node:15440) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'prices' of undefined
    at unitTests (/home/ubuntu/add_test_script_for_uniswap_v3/tests/scripts/uniswap.v3.test.js:188:38)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async /home/ubuntu/add_test_script_for_uniswap_v3/tests/scripts/uniswap.v3.test.js:268:3
(node:15440) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 5)
(node:15440) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

TxN: https://dashboard.tenderly.co/tx/kovan/0x73ac246caba83f24f54f7f795aa71118524c22a024ec958ad75f455590517a15

fengtality commented 3 years ago

The addition of the nonceManager here is intended to fix the approvals issue above for both Uniswap V2 and V3, after this PR and #119 are merged to development.

dennisocana commented 3 years ago

This is 3/3 pull requests we want to merge in the staging phase to be included in this upcoming Friday's release. This includes the fix for https://github.com/CoinAlpha/gateway-api/issues/122. Adding QA as approver to sign-off before merging this in.