Feat/gateway configuration for switching network

CoinAlpha / gateway-api

Apache License 2.0

47 stars 25 forks source link

Feat/gateway configuration for switching network #19

Closed gyozajiro closed 3 years ago

gyozajiro commented 3 years ago

Config endpoint accept Hummingbot ethereum rpc url, ethereum chain, terra lcd url, terra chain and client id.
Instantiate Balancer(), Ethereum(), Terra() in route to load latest chain
Invalidate balancer/sor module cache upon chain switch
Moved Balancer address (Multi, Exchange Proxy, Subgraph URL), Uniswap router to protocol.json static
Remove dependancies on .env variables for chain setting
Load Balancer, Uniswap spenders proxy info from config file

gyozajiro commented 3 years ago

@mifeng @vic-en You can test the config update endpoint using the Postman file (test/postman/Gateway.postman_collection.json). I'll update the client to add the ethereum chain switching based-on the global config.

gyozajiro commented 3 years ago

The conf_global.yml allows us to switch network without restarting the Node server. It did added some complexity and requires re-instantiation of some classes. And it seems to slow down the endpoints from some observations. Due to the performance issue, I have reservations on whether it is worth the change.

james-hummingbot commented 3 years ago

@phbrgnomo Let's get some tasks redesign tasks completed in #44 before trying to add this. I would like to see #63, #64 and #70 done first, then I will refactor this PR into typescript.

dennisocana commented 3 years ago

@vic-en will recreate the PR with some additional updates to the code.