Migrate from env variables to a yaml file

CoinAlpha / gateway-api

Apache License 2.0

47 stars 25 forks source link

Migrate from env variables to a yaml file #89

Closed james-hummingbot closed 3 years ago

james-hummingbot commented 3 years ago

Gateway api currently uses environment variables to store configs. It would be nicer to read from a yaml file. env vars can pollute the shell, especially if someone wants to run multiple gateways with different settings.

evseevnn commented 3 years ago

If software running in docker container then every docker container will have self variables
for not put all variables by environments variables we can use .env file and dotenv package, this file will provide variables without update system environment variables outside.

So, look like better use .env files for that.

james-hummingbot commented 3 years ago

That's a good point about docker. Something to consider is that we don't want this project to be restricted to just hummingbot client or docker though. Some people are interested in using gateway for other applications because it is a nice way to wrap the JS libraries and access them in non-JS projects. Actually development branch already moved to a yaml file. That being said we can still consider the pros and cons of yaml vs env vars.

vic-en commented 3 years ago

I'll be closing this ticket as it has been addressed by https://github.com/CoinAlpha/gateway-api/pull/80