CoinFabrik / scout-soroban

Scout is an extensible open-source tool intended to assist Stellar Soroban smart contract developers and auditors detect common security issues and deviations from best practices.

MIT License

33 stars 2 forks source link

Review test-cases for dos-unexpected-revert-with-vector #256

Closed arturoBeccar closed 1 month ago

arturoBeccar commented 2 months ago

Task

Determine whether it is necessary to split the test case for dos-unexpected-revert-with-vector, one assessing the authorization and the other assessing the usage of vector.

arturoBeccar commented 2 months ago

[x] Split the test case into two to showcase different ways of solving the same issue. The vulnerable test case will be the same in both pairs. In the first pair, remediate the issue requiring authorization by the owner to call add_candidates(). In the second pair, remediate the issue replacing the vector with a mapping like structure using DataKey Enum.
[x] Update all relevant documentation for the vulnerability and detector.