Dividend payment process stuck on loop

[Patrick-Bay]

The nightly dividend payment process (timer_payDividends in the investment plugin), seems to be getting stuck in an infinite loop under certain conditions.

An example of the looping behaviour can be found in the log file:

_/var/log/game_server_debug.log.2018_46.1

...as compared to a normal log:

_/var/log/game_server_debug.log.2018_43.9

Note: These files appear on the development server and can only be viewed via a FTP connection or by remote terminal.

[Patrick-Bay]

This issue will almost certainly involve updates to the timer_payDividends function of the investment plugin in which the dividend payment loop exists.

I expect this fix to take up to 3 hours with testing.

[RiskingTime]

please proceed

[Patrick-Bay]

I've hunted down the issue and committed the fix (https://github.com/CoinRoster/slotmachine/commit/d944adc38829606981cdaf485f782fb157ad61a8). As expected, there was some funny business going on with variables names in the dividend payment loop.

After numerous tests I was unable to reproduce the error and have pulled the changes to the development server where they're available for testing immediately.

[RiskingTime]

let's review this on Wednesday when we meet