search

CoinRoster / slotmachine

fruitgame
0 stars 0 forks source link

negative in-game balance #45

Closed RiskingTime closed 6 years ago

RiskingTime commented 6 years ago

on the "my account" page, the system allows a negative in-game balance to show

Patrick-Bay commented 6 years ago

This may have to do with the withdrawal process triggered on the Admin page for these accounts (it seems like the available balance is being affected when it shouldn't be).

RiskingTime commented 6 years ago

@Patrick-Bay please work on this issue now, there is a chance that there is a negative balance for users game page, and also on their my account page. Let me know what is the plan/time estimate for this.

Patrick-Bay commented 6 years ago

I expect this fix to take approximately 2 hours - 1 hour for investigation and fix application, 1 for testing.

I will begin by looking into the rpc_transferAccountFunds function of the admin plugin, followed, if necessary, by updates to the account page code.

RiskingTime commented 6 years ago

@Patrick-Bay please proceed

Patrick-Bay commented 6 years ago

Fix has been committed (https://github.com/CoinRoster/slotmachine/commit/277fe507b6c8b30d0627c18c2c583901d3758783) and pulled to the dev server where it's available for review immediately.

Please note that any existing accounts with a negative balance will have to be updated manually since there's no handling of negative values (there shouldn't be any!) For the time being, please test only with accounts that have a currently correct positive balance or new accounts.