search

CoinRoster / slotmachine

fruitgame
0 stars 0 forks source link

bankroll deposit transactions missing #59

Open RiskingTime opened 6 years ago

RiskingTime commented 6 years ago

I made a deposit of 0.5 btc, deposited 0.3 to the bankroll, the deposit of 0.5 to the user account shows up in the transaction history, but the deposit to the bankroll is missing. see attached screenshot

deposit_transaction_missing missing_transaction

RiskingTime commented 6 years ago

also noticed that investment deposit transaction also missing from another user account

Patrick-Bay commented 6 years ago

I believe that this issue may be related to issue https://github.com/CoinRoster/slotmachine/issues/53.

I can see in the client code that the transaction information is being received and there's a good indication that it's being excluded in the code section referenced below. I don't expect this issue to take longer than one hour to fix:

https://github.com/CoinRoster/slotmachine/blob/11fdaf37962c48c587e252c6165622ab3bee1beb/html/common/js/account.js#L679-L716

Patrick-Bay commented 6 years ago

Issue has been updated with commit (https://github.com/CoinRoster/slotmachine/commit/1e9717fba04e4088b072da3b5425f1ec86c434c2) and is available on the development server for testing now.

Although this issue should be preceded by a fix for issue #64, I was able to produce this fix while looking deeper into that issue so I thought it'd be best to commit it. This should also allow us to have a more complete history of transactions should it be related to issue #64.

Patrick-Bay commented 6 years ago

Requires additional fix: initial account deposit (from blockchain) doesn't appear in the transaction history. This is most likely caused by the same code and should take < 1 hour to fix.

RiskingTime commented 6 years ago

1 hour paid, another hour of work to come