Closed e1ace closed 6 years ago
Thanks for the pull request. I'll take a look at this later on tonight.
On 18 Dec 2017 2:22 pm, "e1ace" notifications@github.com wrote:
Some API calls were missing. They json response does not seem to match the bittrex documentation but this implementation works.
First time using github so sorry if I'm doing anything incorrectly.
You can view, comment on, or merge this pull request online at:
https://github.com/Coinio/Bittrex.Api.Client/pull/12 Commit Summary
- Added support for deposit and withdrawal history
- Removed incorrect comments
File Changes
- M src/Bittrex.Api.Client/BittrexClient.cs https://github.com/Coinio/Bittrex.Api.Client/pull/12/files#diff-0 (45)
- A src/Bittrex.Api.Client/Models/DepositHistory.cs https://github.com/Coinio/Bittrex.Api.Client/pull/12/files#diff-1 (16)
- A src/Bittrex.Api.Client/Models/WithdrawalHistory.cs https://github.com/Coinio/Bittrex.Api.Client/pull/12/files#diff-2 (15)
Patch Links:
- https://github.com/Coinio/Bittrex.Api.Client/pull/12.patch
- https://github.com/Coinio/Bittrex.Api.Client/pull/12.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Coinio/Bittrex.Api.Client/pull/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AGcI8SQauN6bbtko2gyCPiyUUmjZPxjOks5tBnUZgaJpZM4RFibL .
I've merged your pull request into the project. I might tweak the methods very slightly to use the BuildParameter() method like the other methods but otherwise all good and thanks for the contribution. :)
The nuget package version 1.1.1 should include your changes once it is available on nuget.org.
Some API calls were missing. They json response does not seem to match the bittrex documentation but this implementation works.
First time using github so sorry if I'm doing anything incorrectly.