search

Coksp1 / NBTOOLBOX

Object oriented toolbox for data management, graphics and econometrics.
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

Suggestion to replace nansum() with sum(,'omitnan') #3

Open etolo opened 1 year ago

etolo commented 1 year ago

In General_code\doubleFuncs\nb_mavg.m on line 54 nansum requires "Financial Toolbox" or "Statistics and Machine Learning Toolbox". nansum is not recommended by Matlab.

Suggest to replace with sum(... ,'omitnan').

Original line: xout = (nansum(xback,4) + xin + nansum(xfor,4))./(sum(xback_nzero,4) + sum(xfor_nzero,4) + 1);

Suggested line: xout = (sum(xback,4,'omitnan') + xin + sum(xfor,4,'omitnan'))./(sum(xback_nzero,4) + sum(xfor_nzero,4) + 1);

etolo commented 9 months ago

Related issue in DataManagement\@nb_ts\createShift.m

We had to replace on line 550

mData = nanmean(level,1);

with the following:

mData = mean(level, 1, 'omitnan');