Col-E / Recaf

The modern Java bytecode editor
https://recaf.coley.software
MIT License
6.02k stars 465 forks source link

Better cross version support (Java 8 vs 11) #124

Closed Col-E closed 5 years ago

Col-E commented 5 years ago

Better cross version support

Releases have always been targeting Java 8 due to it's continued popularity. However those that have adopted Java 11 can't run Recaf as easily as the Java 8 users because:


Potential Solutions:

andylizi commented 5 years ago

How about... checking the JVM version when Recaf starts, and (if it's the first time) automatically downloads the required version of JavaFx/ControlsFx, then immediately restarts itself using the accorded launch arguments? Won't be the most elegant of the solutions, but it should work. It's not like there're any rules about a Java application must only consist of a single jar.

Col-E commented 5 years ago

How about...

With 549305b1829a2e540a19c0db3a3adda0cfb20723 I basically did just that.

Col-E commented 5 years ago

andy's approach works and has been implemented as of 1.14.0