search

Col-E / Recaf

The modern Java bytecode editor
https://recaf.coley.software
MIT License
6.02k stars 465 forks source link

Config being incorrectly written, causing first-time prompt to always show #220

Closed Col-E closed 4 years ago

Col-E commented 4 years ago

For some reason config load/save is called twice, and the second write overwrites the config with the wrong values.

10:01:28.088 [main] INFO : Recaf-2.0.1
10:01:28.789 [main] INFO : Discovered plugin 'String Replace-1.0.0'
10:01:28.789 [main] INFO : Discovered plugin 'Theme Editor-1.0.0'
10:01:28.790 [main] INFO : Loaded 2 plugins
10:01:29.383 [main] TRACE: Loading configuration
10:01:31.922 [main] TRACE: Loading configuration
10:01:35.767 [JavaFX Application Thread] TRACE: Exiting FX platform
10:01:35.808 [JavaFX Application Thread] INFO : Shutting down
10:01:35.823 [Thread-8] TRACE: Saving configuration
10:01:35.823 [Thread-4] TRACE: Saving configuration
Col-E commented 4 years ago

Diagnosed by xxDark, its a bug with the updater reverting any changed config values.

Col-E commented 4 years ago

Resolved in #221 , will be in 2.0.2