search

Col-E / Recaf

The modern Java bytecode editor
https://recaf.coley.software
MIT License
6.02k stars 465 forks source link

Recaf not detect changing anymore #869

Closed phucynwa closed 2 days ago

phucynwa commented 2 days ago

I edited a class method then Cmd + S to save. But when I File -> Export application it shows "nothing changed, do you want to save?". Please check and fix it. I'm using Mac OS.

phucynwa commented 2 days ago
System Name Architecture Processors
Mac OS X aarch64 10
Java Version VM name VM vendor Home Supports compiler
23.0.1 OpenJDK 64-Bit Server VM Oracle Corporation /Users/lehongphuc/Library/Java/JavaVirtualMachines/openjdk-23.0.1/Contents/Home true
JavaFX Version
24-ea
Recaf Version Build Settings directory
4.0.0-SNAPSHOT 910ff0b 2024 10/25 05:51 /Users/lehongphuc/Library/Application Support/Recaf
Col-E commented 2 days ago

I edited a class method then Cmd + S to save.

When I make a change via recompiling that is valid, I see the green success flash. Then when I export to a file and open that file I see my change has been applied.

Did you see the green success flash?

If you do not see that, no changes will have been made. I would point you to use the assembler instead if the decompilation isn't good enough to be used for recompilation.

phucynwa commented 2 days ago

No I don't see any green success flash.

But when I try edit a method by Edit -> Make no-op then Export application, it works.

Col-E commented 2 days ago

Like stated, if there's no success flash and you encounter errors you either:

  1. Fix them
    • Subject to incorrect fixes
    • Decompilation is lossy anyways, so some changes may not be inherently obvious or straight forward
  2. Use the assembler
phucynwa commented 1 day ago

@Col-E It just works for making function's body empty, no changing can done.