Changing broken font URL

ColCarroll / ridge_map

Ridge plots of ridges

MIT License

506 stars 45 forks source link

Changing broken font URL #38

Closed atseewal closed 5 months ago

atseewal commented 5 months ago

Not sure if you're actively updating this, but the link to the default font is broken. I updated the default font to point to a Google Fonts version on GitHub.

ColCarroll commented 5 months ago

thanks @atseewal! let me see if i can find the deploy keys now 😹

atseewal commented 5 months ago

Hopefully the Google Fonts is less likely to change their link. That was the change I had to make to get it to run right after install without a 404 error. It works on my machine ^TM

I didn't realize that the change in the readme would get carried back with the pull request! I only changed it in case someone was trying to install from my fork.

ColCarroll commented 5 months ago

Thanks again -- your helpful fix forced me to do 30 mins of work, but I

updated the CI to make pushing quick pypi releases easier
updated the python version that is tested
added a link to a demo colab to quickly see if things are working without spinning up an environment

Maybe I can take another 5 years off 😅 !