ColCarroll / ridge_map

Ridge plots of ridges
MIT License
520 stars 49 forks source link

How easy would be to change the looking angle? #8

Open stratosgear opened 5 years ago

stratosgear commented 5 years ago

Bear with me while I try to explain...

Some kind of angle where:

But tweaking this param would allow you to better frame your points of interest.

ColCarroll commented 5 years ago

That's a good idea! I am a little nervous about tackling it myself, as I am afraid we'll accidentally build a 3d rendering engine, but probably something like https://en.wikipedia.org/wiki/Perspective_(graphical) would work. Right now, we use a grid and manually control the y offsets. If we did the math on how perspective works, we could change that as the y value gets closer to the top of the screen.

anttimc commented 3 years ago

Hi and thanks the authors for this cool package! I I played around with it a bit and happened to find this issue. By a simple linear scaling of x-values towards the top, I could add quite a satisfying illusion of perspective:

kuva

(the elevation data is from Finland, which is not included in the srtm data base apart from the very southern part, so I had to fetch it externally.)

I don't know about fixing the height to the perspective angle. It's conceptually different of what plot_map does currently, so maybe it should be a new function itself (+ some refactoring of the current code, so definitely it could be relatively big feature).