search

Colby-CPU-Sim / CPUSim

GNU General Public License v3.0
52 stars 18 forks source link

Minimizing the MicroInstruction tree does not hide child icons #107

Open moirage opened 7 years ago

moirage commented 7 years ago

In the EditFetchSequence or EditMachineInstructions dialogs, does not hide the icons of all children nodes.

Nava2 commented 7 years ago

I've fixed this in my branch. It was because the treecell wasn't checking for empty, thus wasn't handling clearing itself.

moirage commented 7 years ago

Are you also working on #71 on your branch?

Nava2 commented 7 years ago

Yep, as I commented in #71. Actually, I think I'll have my branch somewhat "stable" to share... probably tomorrow. I'm trying my best not to touch DesktopController, it scares me 😄.

But, I do have the MachineInstructionController simplified, and I'm going to rewrite the opcode building code to just use a HBox + some bindings for width. A lot of the code for this is actually not needed because of how JFX lays things out.