ColbyCommunications / colby-college-theme

Theme for redesigned colby.edu site
MIT License
0 stars 0 forks source link

Use placeholder image for directory teasers and people directory table #26

Closed bwaltz closed 2 years ago

bwaltz commented 2 years ago

Sent the placeholder image through email. This is for when a person has no image. The placeholder looks like this:

colby-buildings-placeholder (1) (1)

gregoryspragginsjr commented 2 years ago

@bwaltz a recent commit I've pushed should cover this: https://github.com/ColbyCommunications/colby-college-theme/commit/8bc7d3573cd2f29c3283dd9c29d78c1fb9248e2e

Let me know if things look good on your end.

bwaltz commented 2 years ago

@gregoryspragginsjr This fixes people directory table. We still need the placeholder to load in the article grid (faculty listing sections in academic depts) if no other image exists for a person:

https://master-7rqtwti-ouiqvb5juucvu.us-4.platformsh.site/academics/departments-and-programs/art/

gregoryspragginsjr commented 2 years ago

@bwaltz I have now applied placeholders to people being pulled in to directory pages. Please be advised, this will only work for people being pulled directly using the posts dropdown on the admin page. When manually adding people to these pages, you'll have to manually pick images still. Please verify on your end and close when ready.

bwaltz commented 2 years ago

@gregoryspragginsjr Awesome! Thanks! I pulled in the changes. How come I don't see any placeholder images on these pages?

https://master-7rqtwti-ouiqvb5juucvu.us-4.platformsh.site/academics/departments-and-programs/art/ https://master-7rqtwti-ouiqvb5juucvu.us-4.platformsh.site/academics/departments-and-programs/science-technology-and-society/

gregoryspragginsjr commented 2 years ago

@bwaltz be sure to set your image orientation to profile for these grid items to default. I've set an example at https://master-7rqtwti-ouiqvb5juucvu.us-4.platformsh.site/academics/departments-and-programs/art/