search

ColdBox / vscode-coldbox

VSCode support for ColdBox
MIT License
6 stars 4 forks source link

Fix lodash not found #23

Closed rodriciru closed 1 year ago

rodriciru commented 1 year ago

Fixes https://github.com/ColdBox/vscode-coldbox/issues/20

This PR fixes that issue, and subsequently, and issue when I cannot get code completion on anything (event, prc, rc....)

Lodash is not found, because in .vscodeignore file there's an ignored node_modules folder, so no lodash is bundled, so not found.

If you remove that line, the extension works, but then you have a massive big extension because when package a vsix, vsce bundles all libraries required in package.json. That's why I moved convert-snippets-to-vscode to devDependencies, uninstall lodash and install lodash per method packages to reduce the bundle size.

In my humble opinion, this extension should be bundled whit webpack but literary this is my second time with VS Code extensions

rodriciru commented 1 year ago

Because the last PR merged, this is now not necessary. I will close that