ColdGrub1384 / LibTerm

iOS sandboxed terminal with Python, Lua and Clang
https://libterm.app
MIT License
639 stars 115 forks source link

Editing command line can hang shell #51

Open treyharris opened 4 years ago

treyharris commented 4 years ago

Just two keystrokes can cause the shell to become unusable.

Steps to reproduce

  1. Open a LibTerm shell.
  2. Type ls or another command, but do not execute it.
  3. Press ⌃a to jump to the beginning of the line.
  4. Press ⌃k to kill the remaining text on the line.

Expected result

The cursor moving to the l in ls and then ls deleted, allowing a new command to be typed.

Actual result

The cursor jumps to column 0 (at the beginning of the shell prompt) after ⌃a: The cursor at the leftmost column of a line reading `Trey Harris’s iPad Pro $ ls`

and then after typing ⌃k to kill the remaining text on the line, the shell prompt is deleted:

The prompt `Trey Harris’s iPad Pro $` disappears At this point, typing ls ⏎ has no effect. ⌃c, ⌃d or ⌃z also have no effect. It appears the shell is totally hung.

Discussion

This issue bears superficial similarity to #27 but is different:

captain commented 5 months ago

How are you even able to type a control character? There are no ctrl, tab, nor ARROW keys anywhere to be found on any of the virtual keyboards. This is the most critically missing feature I have seen so far. 😝