search

ColdGrub1384 / Pisth

SSH and SFTP client for iOS
https://develobile.com/pisth
Apache License 2.0
413 stars 67 forks source link

UI changes to dark theme unexpectedly #9

Closed qkevinto closed 5 years ago

qkevinto commented 5 years ago

The app unexpectedly switches to the dark theme and remains that way until the app is restarted.

The purple text on the dark theme is also fairly inaccessible as well due to the low contrast and makes it rather hard to make out the icons and text.

Steps to reproduce:

  1. Start a connect with SFTP or just regular SSH
  2. Tap on Bookmarks to go back to the list of connections

UI will remain in a dark theme state, even though on app launch it is light themed.

ColdGrub1384 commented 5 years ago

That's expected. The main screen of the app is the "Bookmarks" view. Then when a connection is opened, the screen is replaced by the terminal or the file browser. So, when the "Bookmarks" button is pressed, instead of returning to the bookmarks, the bookmarks are presented on top of the connection with a dark theme on iPhone. On iPad, the app uses a split view so the connection is not completely hidden:

iPad

I wanted to do something like GBA4iOS:

And for the terminal dark theme with purple text, I will make the text lighter.

ColdGrub1384 commented 5 years ago

I made the dark terminal theme more readable, I think it's better now: 53b23a50d70513c7122b9eda88e7e3211df1d756

simulator screen shot - ipad pro 11-inch - 2018-12-02 at 11 41 32

(The buttons are red because I make them red when I'm debugging)

qkevinto commented 5 years ago

Ahh, understood! Thanks for clarifying, as it didn't immediately occur to me what was going on and felt a bit like a bug. Great work and looking forward to the next release!

ColdGrub1384 commented 5 years ago

Thanks for using Pisth!