ColdTrick / profile_manager

Manage profile fields for users and groups in Elgg
https://elgg.org/plugins/385114
30 stars 32 forks source link

sustain each input field access after editing #102

Closed ghost closed 7 years ago

ghost commented 7 years ago

This PR is to keep the current access level to each independent input field after editing. Before the simple access input value affects the access value of each field when the form is initially loaded.

jdalsem commented 7 years ago

simple access is meant to update all access fields to the same value... you can just disable this functionality in the plugin settings. The reason the value is updated when the edit form loads is that i think the simpleaccess input should reflect the actual situation

ghost commented 7 years ago

It's true the simple access functionality can be disabled and in fact it's disabled by default. It's my fault that I forgot I made some changes to the edit form before to make every independent field available to the user as well. However, I still think my point makes more sense. Consider this user scenario:

In fact, even I tried in a fresh elgg installed site, after I changed all of the fields to private and go back to edit my profile again, the simple access field still shows public, so it didn't reflect the actual situation per se.

jdalsem commented 7 years ago

As the suggested change is not how i intend the usage of the 'simple access' feature i am closing this PR