search

ColeBennett / binance-auto-blacklist

Automatically disables trading for new Binance listings in ProfitTrailer
34 stars 6 forks source link

A way to get it to work with PTMagic? #18

Open krejler opened 6 years ago

krejler commented 6 years ago

First I like to say i love this plugin. Second I would love to hear, can I get it to work with PTMagic? Cheers

juato4 commented 6 years ago

add me to the ask!

Fransenson commented 6 years ago

Same here. I tried recompiling the .java file from your git with "trading" replaced with "Default" and putting the resulting .jar file as well as the blacklist.properties next to the default settings folder in PTMagic. Unfortunately my .jar seems to be corrupt.

@bennettca If you don't use PT Magic: All we need is a variable setting in the blacklist.properties to point at the path of the PAIRS.properties instead of the hardcoded path. Would this be possible?

Zamboniman commented 6 years ago

@Fransenson I had no problem recompiling it with maven after making the directory change. It seems to be working fine for me. I still have a bit of testing to do, but I think this solved the issue for using this with PTMagic nicely.

Of course, it only works properly if PT Magic makes a change and copies the changed file over to Profit Trailer. So ideally this would check and modify both files simultanteously.

The current workaround is to run both simultaneously, the original in the Profit Trailer folder and this one in PTMagic.

@bennettca What's the license for this? Can I distribute my modified version?