ColeBennett / binance-auto-blacklist

Automatically disables trading for new Binance listings in ProfitTrailer
34 stars 6 forks source link

awesome....buttt....SOM instead of trading disabled #3

Closed sethiano closed 6 years ago

sethiano commented 6 years ago

I think it would better if you can change it to SOM for the Black list instead of trading disabled, just incase it misses a coin in the very beginning and you get stuck with it.

dillonm1075 commented 6 years ago

I agree. I'm concerned that if I already have some of those blacklisted coins in bags Ill be stuck with them. The script definitely needs some logic added to recognise that it has to sell those coins first before it blacklists them

colinbrinton commented 6 years ago

Absolutely agree. It makes more sense to allow users to sell of bags they may already be holding.

daryledesilva commented 6 years ago

som mode instead of disabling trading is now supported with latest rls

nmalancea commented 6 years ago

@daryledesilva I think SOM is fixed in the code but not yet packaged in a release (https://github.com/bennettca/binance-auto-blacklist/issues/8#issuecomment-362863247). The .jar file doesn't contain the latest commit. cc: @bennettca