search

ColeWalker / twitch-graphql

A GraphQL wrapper for the twitch api
MIT License
14 stars 2 forks source link

Tests are still hitting the twitch api #140

Open ColeWalker opened 4 years ago

ColeWalker commented 4 years ago

Some of our tests are still hitting the twitch api, which is not ideal for rapid testing.

CodeItQuick commented 4 years ago

Thanks Cole, I'll see if I can tackle some of this, no promises yet

CodeItQuick commented 4 years ago

This was a misunderstanding/miscommunication on my part and can be closed?

CodeItQuick commented 4 years ago

I added a PR that addresses one of the endpoints that currently hits the Twitch API and significantly speeds up the tests.

ColeWalker commented 4 years ago

User-subscriber link still hits twitch api. https://d-fischer.github.io/twitch/reference/classes/HelixSubscription.html