search

ColemanGariety / gulp-soften

A gulp task that converts hard tabs to spaces.
4 stars 0 forks source link

Streaming support #2

Open sindresorhus opened 10 years ago

sindresorhus commented 10 years ago

Since this is just replacing characters it should be easy to add streaming support.

ColemanGariety commented 10 years ago

@sindresorhus can you elaborate? It works going into a pipe(), how can it be improved?

sindresorhus commented 10 years ago

gulp can support streams of streams, not just streams of buffers like most tasks supports. This is good case where streaming could be supported. See https://github.com/lazd/gulp-replace/commit/42a34965ca3cb1b151594da96ebb063d1e330351 and read the plugin guidelines ;)

ColemanGariety commented 10 years ago

@sindresorhus ah, so the soften() function should return a writable stream so you can write data to it and it'll soften it?

sindresorhus commented 10 years ago

It should support streaming as gulp-replace does.

sindresorhus commented 10 years ago

@JacksonGariety friendly ping :)

ColemanGariety commented 10 years ago

@sindresorhus sorry I missed this message, I'll take a look at gulp-replace.