ColemanResearchGroup / MHQ2

Code for deriving phenotypes from the second Mental Health Questionnaire in UK Biobank
MIT License
1 stars 1 forks source link

Mania code review #15

Closed mJaredg closed 11 months ago

mJaredg commented 1 year ago

I have used the algorithm to define mania in UK Biobank. I will adapt the code to tidyverse when testing and after code review

JoniColeman commented 11 months ago

Set 1 checks are above. Pushed commit provides changes I have suggested, so can be downloaded and sanity-checked.

JoniColeman commented 11 months ago

Set 2 review can be achieved by putting code through lintR as below:

library(lintr)
mhq_lints <- linters_with_defaults(
    object_name_linter(styles = c("symbol", "CamelCase", "snake_case", "lowercase"))
)

lint("scripts/MHQ2_Mania_v1.Rmd", linters = mhq_lints, exclude = "##")
JoniColeman commented 11 months ago

Approved and merged.