Closed dolfandringa closed 1 year ago
Few small oversights, last one was a formatting issue in the README.md docs. All tests are present and passing, both sync and async.
Now really fixed, after I ran coverage
and discovered I missed something
Seems like a nice feature, thanks for tackling this up! I think I will tweak it a bit after merge but this would only be cosmetics. I don't have time to invest in it right now however. Is it ok if I try to tackle this next week ?
Could you rename match_json_content into matchjson ? It would follow a bit more the structure where we provide match{name_of_the_httpx_parameter}
Cool, will do. To stay in the same theme, I also renamed self.match_json
to self.json
(like self.content
)
Thanks for the comments. They made sense. I think I addressed them all.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
closes #83 Added the match_json_content matcher which checks if the passed object matches the json decoded request body
I preferred adding a new matcher
match_json_content
over modifying the existingmatch_content
.I could have added conditions that if the
match_content
argument isn't of typebytes
then assume we want to json decode the body, but that doesn't match nicely with Explicit is better than implicit., and with the extra argument I think the code also stays cleaner.