search

Colin-b / pytest_httpx

pytest fixture to mock HTTPX
https://colin-b.github.io/pytest_httpx/
MIT License
344 stars 32 forks source link

Support Python >= 3.8, <3.12 & httpx >= 0.23.0 #123

Closed foarsitter closed 10 months ago

foarsitter commented 10 months ago

This PR loosens the versions constraints for Python so it supports 3.8. Some typing's are changed to become compatible with 3.8. Furthermore the test matrix is extended to test against the latest 3 httpx versions and Python 3.12.

Closes #122

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

r2rstep commented 10 months ago

+1 for that

nicolewhite commented 10 months ago

@Colin-b could this be merged? 😇

Colin-b commented 10 months ago

Hello @foarsitter

Thanks for your contribution, this is however a duplicate of #112. The addition of 3.12 is however a welcome contribution in a dedicated PR.

Thanks again

nicolewhite commented 9 months ago

@Colin-b this was not a duplicate, this also fixed the issue where you're expecting an exact version of httpx:

https://github.com/Colin-b/pytest_httpx/blob/b8aaadd8d4a10d4a0f306d92c2b5610707bbbcdf/setup.py#L43

without this fix, libraries that want to support any version of httpx cannot use your library to test httpx