search

Colin-b / requests_auth

Authentication classes to be used with requests
MIT License
35 stars 13 forks source link

Enable domain name to be provided to authentication.BrowserAuth #75

Closed ManojSN closed 4 months ago

ManojSN commented 2 years ago

Hi Colin,

Please review the change and comment, I'll update the documentation add test cases when I get home.

The change is to allow domain name to be passed as an optional keyword arg. We have our OKTA setup in such a way that our company domain name is required even for localhost such as http(s)://localhost.somecompany.com:/<redirect-uri

Thanks

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ManojSN commented 2 years ago

@Colin-b -> pls review! as for the use of http://localhost triggering a sonar warning, guessing only you can accept the risk!

Colin-b commented 4 months ago

Hello @ManojSN ,

Took 2 years but this will be part of the next release.