Unable to maximize window on 1280x720 screens

vaurelios commented 6 years ago

Description:

The Window of Mellow Player doen't maximize
The Window of Mellow Player has height greater than desktop height

Steps To Reproduce:

Just launch Mellow Player and observe

Log Files

Paste the application logs (About > Show logs)

[2018-04-11 22:51:42.424] [All] [info] *******************************************************************************
[I] [2018-04-11 22-51-43:053037] [StreamingServiceLoader] 8tracks streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/8tracks")
[I] [2018-04-11 22-51-43:053274] [StreamingServiceLoader] Anghami streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/anghami")
[I] [2018-04-11 22-51-43:053617] [StreamingServiceLoader] Bandcamp streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/bandcamp")
[I] [2018-04-11 22-51-43:053871] [StreamingServiceLoader] Deezer streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/deezer")
[I] [2018-04-11 22-51-43:054083] [StreamingServiceLoader] Google Play Music streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/googleplaymusic")
[I] [2018-04-11 22-51-43:054298] [StreamingServiceLoader] HearThisAt streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/hearthisat")
[I] [2018-04-11 22-51-43:054506] [StreamingServiceLoader] HypeMachine streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/hypemachine")
[I] [2018-04-11 22-51-43:054710] [StreamingServiceLoader] Jamendo streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/jamendo")
[I] [2018-04-11 22-51-43:054947] [StreamingServiceLoader] Mixcloud streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/mixcloud")
[I] [2018-04-11 22-51-43:055140] [StreamingServiceLoader] Player FM streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/playerfm")
[I] [2018-04-11 22-51-43:055357] [StreamingServiceLoader] Plex streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/plex")
[I] [2018-04-11 22-51-43:055565] [StreamingServiceLoader] Pocket Casts streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/pocketcasts")
[I] [2018-04-11 22-51-43:055762] [StreamingServiceLoader] Radionomy streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/radionomy")
[I] [2018-04-11 22-51-43:055961] [StreamingServiceLoader] Soundcloud streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/soundcloud")
[I] [2018-04-11 22-51-43:056174] [StreamingServiceLoader] Spotify streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/spotify")
[I] [2018-04-11 22-51-43:056370] [StreamingServiceLoader] Tidal streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/tidal")
[I] [2018-04-11 22-51-43:056576] [StreamingServiceLoader] TuneIn streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/tunein")
[I] [2018-04-11 22-51-43:056803] [StreamingServiceLoader] Wynk streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/wynk")
[I] [2018-04-11 22-51-43:056999] [StreamingServiceLoader] ympd streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/ympd")
[I] [2018-04-11 22-51-43:057198] [StreamingServiceLoader] Youtube streamingService successfully loaded (from "/tmp/makepkg/mellowplayer/src/MellowPlayer-3.3.5/plugins/youtube")

Additional Information:

Version: 3.3.5.0
Affected streaming services (if any):
Operating System: ArchLinux (Mate-Desktop); AUR package.

ColinDuquesnoy commented 6 years ago

Thank you for reporting.

I can see the window has a minimum size set to 1280x720.

What is the resolution of your screen? I need that information to make sure everything still fits well in a smaller window.

vaurelios commented 6 years ago

It's 1360x768

But there's 2 mate-panel of 24px each.

ColinDuquesnoy commented 6 years ago

@vaurelios Thank you for the information. Theorically it should be good but I guess there might be a few pixels lost in e.g. window decoration. I'll investigate the issue as soon as I find some free time (I am very busy with IRL stuff at the moment...)

ColinDuquesnoy commented 6 years ago

I've reduced the minimum size to 960x540, that should fix your issue. The fix is in the develop branch, to try it out you need to compile MellowPlayer from source

vaurelios commented 6 years ago

And about the maximize problem?

ColinDuquesnoy commented 6 years ago

Should be fixed as well (same issue related to the minimum size of the window). Do you still have an issue with maximize?

ColinDuquesnoy / MellowPlayer