search

ColinDuquesnoy / MellowPlayer

Moved to gitlab
https://gitlab.com/ColinDuquesnoy/MellowPlayer
GNU General Public License v2.0
233 stars 23 forks source link

YouTube Music Addon v1 #268

Closed NicolasGuilloux closed 6 years ago

NicolasGuilloux commented 6 years ago

Add Youtube Music addon (Fix #254)

Youtube Music MellowPlayer

daugustin commented 6 years ago

Maybe you could also edit the README.md to include the new service?

NicolasGuilloux commented 6 years ago

Can people try it on several plateform to be sure that it works on every OS ?

daugustin commented 6 years ago

Compiled your branch on Linux, Youtube Music works, Hotkeys work.

NicolasGuilloux commented 6 years ago

I noticed a bug: the artist does not change when the music changes. I'll try to fix that ;)

NicolasGuilloux commented 6 years ago

I don't understand why it's not working. To reproduce, just change songs. See what's returned: Issue

It seems right and should change the artist name but it's not. And I can't find why. Maybe it's a bug on my installation ? Do you have the same ?

daugustin commented 6 years ago

The notification is correct and the topbar is changing too...

NicolasGuilloux commented 6 years ago

Done ! For the Artist Name, it may be my computer. Don't worry ;) Cheers guys !

ColinDuquesnoy commented 6 years ago

Thank you very much. I'll review this pull request ASAP (probably during the weekend).

For the Artist Name, it may be my computer. Don't worry ;)

I do worry, this could be a bug. Just in case, could you please compress the logs directory (~/.local/share/MellowPlayer/Logs) in a tar.gz archive and attach it here?

NicolasGuilloux commented 6 years ago

I looked at the Logs and apparently, the changes of artist where displayed in the Logs so I really don't know where is the issue. Anyway, I attached the logs to this comment.

Logs.tar.gz

ColinDuquesnoy commented 6 years ago

@NicolasGuilloux I looked at the logs and didn't see anything suspicious. Does it still happen after you restarted MellowPlayer and/or your computer?