ColinDuquesnoy / MellowPlayer

Moved to gitlab
https://gitlab.com/ColinDuquesnoy/MellowPlayer
GNU General Public License v2.0
234 stars 23 forks source link

MPRIS metadata album is missing when playing with Spotify #272

Closed mariusor closed 6 years ago

mariusor commented 6 years ago

Description:

The information exposed through the MPRIS Properties DBUS property doesn't contain the Album data, but an empty string.

Steps To Reproduce:

  1. Play song in MellowPlayer (I was using Spotify)
  2. Execute dbus-send --print-reply --type=method_call --dest=org.mpris.MediaPlayer2.MellowPlayer /org/mpris/MediaPlayer2 org.freedesktop.DBus.Properties.Get string:org.mpris.MediaPlayer2.Player string:Metadata

The response is:

method return time=1534436480.086215 sender=:1.22586 -> destination=:1.22603 serial=84 reply_serial=2
   variant       array [
         dict entry(
            string "mpris:artUrl"
            variant                string "file:///home/{username}/.cache/MellowPlayer/Covers/195627029"
         )
         dict entry(
            string "mpris:length"
            variant                int64 444000000
         )
         dict entry(
            string "mpris:trackid"
            variant                string "/org/mpris/MediaPlayer2/Track/195627029"
         )
         dict entry(
            string "xesam:album"
            variant                string ""
         )
         dict entry(
            string "xesam:artist"
            variant                array [
                  string "Bjørn Riis"
               ]
         )
         dict entry(
            string "xesam:title"
            variant                string "The Waves"
         )
         dict entry(
            string "xesam:url"
            variant                string "The Waves"
         )
         dict entry(
            string "xesam:userRating"
            variant                int32 0
         )
      ]

Additional Information:

mariusor commented 6 years ago

I did some superficial investigations about this and the problem seems to be that the Spotify web interface doesn't have any obvious place where the Album can be loaded from. If I have some time I'll take a closer look, maybe fix the artist list too in the case where there are multiple.

ColinDuquesnoy commented 6 years ago

@mariusor Thanks for reporting and investigating. As you've realized, this issue really depends on the capabilities of a specific plugin. I am going to close this as invalid as there is no bug in the MPRIS implementation but only a limitation in some plugins.

Feel free to contribute to the spotify plugin :wink: :+1: