ColinDuquesnoy / MellowPlayer

Moved to gitlab
https://gitlab.com/ColinDuquesnoy/MellowPlayer
GNU General Public License v2.0
234 stars 23 forks source link

Generic way to control volume regardless of the streaming service #282

Open doh38 opened 6 years ago

doh38 commented 6 years ago

Description:

I use Kde-connect with your player. This is a neat tool allowing me to control any player from android and actually the main reason I use your player instead of the web page ;) Nearly everything works EXCEPT the volume control (it works with for example Rythmbox). I asked the guys from KDE connect and they told me :

"The player volume control is defined in the MPRIS2 specification. Players should adhere to that."

That's now the only issue I have with your player. Kde-Connect will release a "main volume control" soon, and that will solve this issue (I use a workaround currently having recorded terminal command for Vol+ and - from terminal and can then, with a few menu, reach my goal :) That's said. Is it a bug? Is there any reason for non compliance?

Steps To Reproduce:

  1. Start player
  2. Start Kde connect
  3. try to change volume from app, not happening ^^

Log Files

/nolog

Additional Information:

ColinDuquesnoy commented 6 years ago

Not all streaming service plugins support setting the volume. Soundcloud plugin does not support it yet. Deezer supports it.

Maybe we can see if there could be a generic way to control the QtWebEngine audio level regardless of the streaming service and move that functionality out of plugins. I'll investigate.

doh38 commented 6 years ago

Thanks Colin! Great to hear :)

ColinDuquesnoy commented 5 years ago

This issue has been moved to our new gitlab issue tracker.

The github repository will be archived soon and this issue will become read-only. We suggest you continue the discussion and follow the progress on this issue at gitlab.