search

ColinDuquesnoy / QDarkStyleSheet

A dark style sheet for QtWidgets application
Other
2.76k stars 726 forks source link

Remove blue outline for hover in panes and add focus to QColumnView #258

Closed juanis2112 closed 3 years ago

juanis2112 commented 3 years ago

As stated in https://github.com/spyder-ide/ux-improvements/issues/27 we discussed with @ccordoba12 and @isabela-pf about removing the blue outline for the hover state of the panes because it is confusing to have both (the hovering and the focus one).

This PR removes the hovering for the QTextEdit, QPlainTextEdit and QColumnView corresponding to the Editor, Console and the panes in the upper right corner in Spyder. It also adds the focus state to the QColumnView since it currently doesn't have it so the panes at the upper right corner don't have the blue outline when focused.

In the following gif we can see the behaviour for spyder with this PR:

hover

Please @dpizetta let us know if this change is possible.

ccordoba12 commented 3 years ago

Thanks a lot for this @juanis2112!

@dpizetta, we noticed that it's confusing for users to show this border when hovering, but it's quite natural to do it when a pane has focus.

dpizetta commented 3 years ago

Hi guys, I agreed! I'll check the code and return soon. Tks

ccordoba12 commented 3 years ago

Thanks @dpizetta!