ColinDuquesnoy / QDarkStyleSheet

A dark style sheet for QtWidgets application
Other
2.76k stars 726 forks source link

Improve selected tab background color and title contrast #270

Closed dpizetta closed 3 years ago

dpizetta commented 3 years ago

What do you think @juanis2112, @ccordoba12 and @isabela-pf.

Original

image

Changing the background color of the selected tab (tab bar), using background 4 (the same as non selected, original is background 6). Note the title contrast when the background is darker. For me, the blue bar is sufficient to point to the selected one.

image

Changing the background color of the selected tab (tab bar), using background 5 (lighter than non-selected, original is background 6). Yet I prefer the same background to enhance the title contrast.

image

ccordoba12 commented 3 years ago

Changing the background color of the selected tab (tab bar), using background 5 (lighter than non-selected, original is background 6). Yet I prefer the same background to enhance the title contrast.

I know this is quite subjective, but I really prefer to have a lighter color for selected tabs. However, we could adjust that on Spyder if you prefer the same color.

dpizetta commented 3 years ago

The current one, same colors, light theme:

image

juanis2112 commented 3 years ago

I agree with Carlos. I think it looks better with different colors between the tabs but we can implement that easily only for Spyder if you want to change it @dpizetta

dpizetta commented 3 years ago

I've set a mid-tone (the original was 6, identical was 4), now it is 5. Tks guys