Fix generating assets per operating system

ColinDuquesnoy / QDarkStyleSheet

A dark style sheet for QtWidgets application

Other

2.81k stars 729 forks source link

Closed ccordoba12 closed 3 years ago

ccordoba12 commented 3 years ago

The shell kwarg to subprocess.call can't be True in Posix systems.

ccordoba12 commented 3 years ago

@dpizetta, I'm assuming you made shell=True because you needed to generate the assets on Windows before releasing QDarkStyle 3.

This change makes things work again for Posix systems (i.e. Linux and macOS), where our scripts were broken due to that.

ccordoba12 commented 3 years ago

Hey @dpizetta, have you had time to take a look at this?

dpizetta commented 3 years ago

Hey @ccordoba12, thanks for that.

ccordoba12 commented 3 years ago

Thanks @dpizetta!