search

ColinDuquesnoy / QDarkStyleSheet

A dark style sheet for QtWidgets application
Other
2.81k stars 729 forks source link

External "link" buttons display in default blue #294

Closed DannyyyOnGit closed 3 years ago

DannyyyOnGit commented 3 years ago

Describe Your Environment

Dolphin Emulator end user. Theme properly edited to support the custom themes feature. No custom compile or anything similar. Directly downloaded from here and changed some qss file paths for Dolphin.

The issue I'm experiencing is that external "hyperlink" buttons don't seem to have any property, in order to define their color. Basically leaving them default blue, which doesn't go well with the theme in general. I'm not sure if this is an issue with Dolphin not reading an existing definition properly or this type of button not having any definitions at all.

Info

Description / Steps to Reproduce

  1. Put "QDarkStyleSheet" folder into source folder (where dolphin.exe is)
  2. Put "QDarkStyleSheet.qss" into C:\Users\YOURNAMEHERE\Documents\Dolphin Emulator\Styles
  3. Open Dolphin Config > Interface and check "Use Custom User Style" (app restart might be required)
  4. Select "QDarkStyleSheet" user style with optional general theme color
  5. Open "About" under "Help" menu

Actual Result

External links have a blue color, which doesn't go well with the theme's background color.

Screenshot: image

Expected Results / Proposed Result

Shouldn't be blue and fit with the rest of the theme (perhaps grey).

ccordoba12 commented 3 years ago

Hey @DannyyyOnGit, thanks for reporting. You said

Dolphin Emulator end user

Is that a C++ or Python app?

DannyyyOnGit commented 3 years ago

Is that a C++ or Python app?

C++ based on their Git: https://github.com/dolphin-emu/dolphin

DannyyyOnGit commented 3 years ago

Here is the about dialog. From the looks of it, Dolphin uses simple hyperlinks. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/DolphinQt/AboutDialog.cpp

I guess my question would be, how replacing the styling for that would look like? Any help is appreciated. Might also be worth to include the styling definition for future use as well.

DannyyyOnGit commented 3 years ago

After some more research. This seems to be caused by a Qt limitation: https://stackoverflow.com/questions/13416183/qt-stylesheet-how-to-set-color-of-qpalettelink-and-qplattelinkvisited

I've talked with the Dolphin app developers and they might add a workaround for this in the future. (Closing since this is an external issue.)