search

ColinDuquesnoy / QDarkStyleSheet

A dark style sheet for QtWidgets application
Other
2.76k stars 725 forks source link

Fix background color of widgets in QToolBox #323

Closed alexispr1 closed 1 year ago

alexispr1 commented 1 year ago

The background color of widgets placed in QToolBox doesn't appear for dark and light themes:

Bug_backround_widgets_in_qtoolbox Bug_light_backround_widgets_in_qtoolbox

After having modified style sheets:

Fix_backround_widgets_in_qtoolbox Fix_light_backround_widgets_in_qtoolbox

ccordoba12 commented 1 year ago

Hey @alexispr1, thanks for your contribution! This looks good to me, but please remove the changes to the rc files from your commit. They are regenerated before each release with all changes done to the qss files.

ccordoba12 commented 1 year ago

@alexispr1, I'm afraid your pull request is a bit messed up, so it would be better if you can redo it in another one.

So, pull requests in this repo are done against the develop branch, not master. And I just saw that you pushed your commits directly to the master branch of your fork. Instead, please create a branch derived from the develop one for your new pull request.

Unfortunately, I can't help you to do that here because your pull request was not made from a branch.