search

ColinEberhardt / VCTransitionsLibrary

A collection of iOS7 animation controllers and interaction controllers, providing flip, fold and all kinds of other transitions.
Other
4.55k stars 617 forks source link

do not rely on container view frame values, rm hardcoded screensize #12

Closed xinsight closed 10 years ago

xinsight commented 10 years ago

This was a fun one to debug! If a view has a transform the frame values have undefined behaviour. The containerView in the custom UIView controller has a transforms when the the device is in landscape orientation. The cards transition was using the containerView frame, so it works on the ipad in landscape.

Also a tiny fix to remove the hard coded screensize in the fold transition.

ColinEberhardt commented 10 years ago

Great - many thanks for this. I've committed the change here:

https://github.com/ColinEberhardt/VCTransitionsLibrary/commit/0b80e51fbb853569992b47841b31e9f0c1826d52

I've made a few small amendments here:

https://github.com/ColinEberhardt/VCTransitionsLibrary/commit/3b0ae94ea32bc1fbf23796dcde7097cda63fd13b