search

ColinEberhardt / VCTransitionsLibrary

A collection of iOS7 animation controllers and interaction controllers, providing flip, fold and all kinds of other transitions.
Other
4.55k stars 616 forks source link

[ADDED] Cube animation #18

Closed andresbrun closed 10 years ago

andresbrun commented 10 years ago

Hi Colin,

I have my own transition library for iOS6 in which I have implemented others effects. I've integrate cube effect in your library because it looks very interesting.

Navigation a presentations works fine but I had some issue using the swipe interaction :S. I hope you can solve it!

Best! Andrés

ColinEberhardt commented 10 years ago

Wow, those are some really cool transitions :-)

I'll see if I can work out what the issue is with the interactive transitions.

ColinEberhardt commented 10 years ago

Looking at your code, I have a feeling the issue is because you place the from- and to- views within a newly added subview.

I quickly hacked your code to remove the generalContentView, and it seems to work now. See the code in this branch:

https://github.com/ColinEberhardt/VCTransitionsLibrary/tree/andresbrun-master-quickfix

andresbrun commented 10 years ago

Yeah! Thanks for the solution, I was becoming crazy. It is solved and working now :) Maybe in the future I integrate the square flip transition ;)

ColinEberhardt commented 10 years ago

Cool - I'll merge this shortly. Thank you very much for the contribution.

If you do get the time, the square flip animation would be great as well, it looks very cool!

ColinEberhardt commented 10 years ago

Many thanks for this - I've merged your changes :-)