search

ColinEberhardt / VCTransitionsLibrary

A collection of iOS7 animation controllers and interaction controllers, providing flip, fold and all kinds of other transitions.
Other
4.55k stars 617 forks source link

split wiring pop-interaction controller & animator #26

Closed DivineDominion closed 8 years ago

DivineDominion commented 10 years ago

At first I found it hard to follow why -navigationController:animationControllerForOperation:fromViewController:toViewController: was wiring the interaction controller to toVC. After some fiddling in my own app, I found the real event you meant was when a view controller is pushed on the stack to prepare the pop transition.

I find the change makes the intent clear and the code easier to follow.

ColinEberhardt commented 8 years ago

Thanks - I'm happy with this refactor.