Now using a native html <button> for instant a11y improvements, including keyboard focusability and semantics.
Other improvements:
Clap count is no longer positioned outside component bounds, which users needed to know about and allow for on their pages
Now only need to set width on applause-button element, not height, as aspect ratio of the button is fixed as square
Styles and event-handling code have been tidied as a result of using html button
I must admit, this one is non-trivial to review as there are plenty of changes, including to the stylesheet, which I tried to simplify a little. In a subsequent PR I will simplify this further by junking SASS in favour of pure CSS.
I suggest you check it out, run it locally using yarn test:serve then view it / click it a bit to see how it behaves. Note you'll need Node >= 18.17 to run it.
Now using a native html
<button>
for instant a11y improvements, including keyboard focusability and semantics.Other improvements:
I must admit, this one is non-trivial to review as there are plenty of changes, including to the stylesheet, which I tried to simplify a little. In a subsequent PR I will simplify this further by junking SASS in favour of pure CSS.
I suggest you check it out, run it locally using
yarn test:serve
then view it / click it a bit to see how it behaves. Note you'll need Node >= 18.17 to run it.