Closed ColinEberhardt closed 3 years ago
I tried 0.18 version from this PR on node v15 and everything works fine:
untouched.wasm:
baseline x 103,084 ops/sec ±1.14% (88 runs sampled)
character class x 28,805 ops/sec ±0.52% (89 runs sampled)
concatenation x 8,267 ops/sec ±0.61% (91 runs sampled)
quantifiers x 15,565 ops/sec ±0.96% (86 runs sampled)
range quantifiers x 5,022 ops/sec ±0.56% (89 runs sampled)
alternation x 16,263 ops/sec ±0.63% (88 runs sampled)
multiple regex matches x 1,723 ops/sec ±0.44% (86 runs sampled)
optimized.wasm:
baseline x 205,100 ops/sec ±0.66% (89 runs sampled)
character class x 58,661 ops/sec ±0.76% (88 runs sampled)
concatenation x 15,636 ops/sec ±0.37% (89 runs sampled)
quantifiers x 30,233 ops/sec ±0.51% (88 runs sampled)
range quantifiers x 9,227 ops/sec ±0.39% (84 runs sampled)
alternation x 29,869 ops/sec ±0.70% (88 runs sampled)
multiple regex matches x 2,309 ops/sec ±1.03% (86 runs sampled)
Ah I was just about to try a benchmark, thanks for checking this @MaxGraey ! :smile: :tada:
Currently the CI tests (that run
npm test
) use node v15. However, the benchmarks use the default node version, which happens to be v10.When running the benchmarks on node v15 they fail as follows:
Ideally everything should run on the same node version!