refactor: extract constants

ColinEberhardt / assemblyscript-temporal

An implementation of TC39 temporal for AssemblyScript

24 stars 6 forks source link

Closed SebastianSpeitel closed 3 years ago

SebastianSpeitel commented 3 years ago

I don't know how useful this would be, but there are a lot of constants, that can be extracted.

A few downsides I could see are:

is either float or int and we would need some of them as both types to reduce implicit casting (if the compile can't do that at compile time)
I don't know how well those constants can be inlined

SebastianSpeitel commented 3 years ago

There are a lot more than the ones extracted here.

ColinEberhardt commented 3 years ago

Thanks @SebastianSpeitel that's a good idea 👍

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: