search

ColinEberhardt / assemblyscript-temporal

An implementation of TC39 temporal for AssemblyScript
24 stars 6 forks source link

Improvements to instant #58

Closed SebastianSpeitel closed 3 years ago

SebastianSpeitel commented 3 years ago

Use preexisting methods and constants Don't create temporary duration instances if possible

ColinEberhardt commented 3 years ago

Thanks for these changes, much appreciated.

Don't create temporary duration instances if possible

In this instance, I'd prefer to keep the code the way it was. At the moment I am undertaking a fairly significant refactoring of the codebase (see this branch https://github.com/ColinEberhardt/assemblyscript-temporal/tree/refactor). It helps to keep the code simple (rather than performance optimised) during refactor.

Performance optimisation can be a step after that!

SebastianSpeitel commented 3 years ago

Now this PR only includes the constants.

ColinEberhardt commented 3 years ago

Thanks @SebastianSpeitel

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: