Polish - Githubissues

ColinEberhardt commented 6 years ago

[x] Font family (looks to be using a very light font, Helvetica Neue or Nimbus Sans)
[x] Legend styling (grey labels, black text, title case, transparent?)
[ ] Legend content (time not shown, vol & change shown)
[ ] Pixel snapping (doesn't look universally crisp or soft)
[ ] Series labels
[x] Axis style (black versus grey)
[x] X Axis label styling (bold)
[x] X Axis tick style (length)
[ ] X Axis tick position (first of day)
[ ] Y Scale padding (theirs seems to be symmetrical but ours seems offset)
[x] Y Axis width (too small)
[x] Y Axis label (remove right offset, reduce bottom offset)
[ ] Y Axis vertical bars (edge of plot area (possibly consequence of data), edge of chart)
[x] Y Axis annotation label (not veritically centered)
[x] Y Axis annotation position (no margin to plot area)
[x] Chart top border
[ ] EMA series (not shown for close periods)
[x] Vertical band line style (dotted)
[x] Vertical band axis tick (triangle)
[x] Vertical band background (can't tell but ours seems to be slightly darker)
[x] Vertical band sigels ("funky icons")
[ ] Crosshair (not sure on yahoo styling but we should probably not use our out the box styling)
[ ] Watermark (figured we could have some fun with the words)
[x] Blue lines at top (not sure what these are)
[x] Volume bar styling (colour more faded)

ColinEberhardt commented 6 years ago

Blue lines at top (not sure what these are)

I think these are underlined menu options from UI that has been cropped from the image

ColinEberhardt commented 6 years ago

EMA series (not shown for close periods)

ColinEberhardt / yahoo-finance-d3fc