ColinFay / attempt

Tools for defensive programming in R
Other
124 stars 12 forks source link

discretly or discreetly? #12

Open turgeonmaxime opened 5 years ago

turgeonmaxime commented 5 years ago

Awesome package! I've always found the interface to try and tryCatch confusing.

But I hate to be that person: I think you made a typo in calling your function discretly. I imagine you were going for discreetly (with two es), meaning:

In a careful and prudent manner, especially in order to keep something confidential or to avoid embarrassment. (from the OED)

You probably don't want to break code by changing the name of the function, but you could alias one or the other (and maybe output a message when discretly is called).

ColinFay commented 5 years ago

Don't hate being that person — I'm not a native English speaker and on the contrary find it very useful when people come with feedback about. So thank you.

It's actually pretty easy to implement without making breaking change — I'll just rename discreetly to discretly and have a

#' @export
#' @nord
discretly <- discreetly

So that the function is still available, but with no documentation.