search

ColinGilbert / projectzombie

Automatically exported from code.google.com/p/projectzombie
0 stars 1 forks source link

Project Zombie code review 0 #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This is an overall code review request:

-EngineController:
Review the entire EngineController system.

-Game States:
Review the game state system.

-Command and Control:
Review the command and control system.

Note:
For each system, please input any issues, objections, and thoughts.

Original issue reported on code.google.com by LLw...@gmail.com on 21 Aug 2010 at 12:40

GoogleCodeExporter commented 9 years ago 
-EngineController:
*Problem with "dependency injection" as it was left unfinished. 
This has been refactored and I suppose it's finished. Now the dependencies are 
created in EngineController, and are injected into GameState for configuration, 
then injected during onInit event to be used for initialization. 
Sure, we're not doing "true" "dependency injection" because we are manually 
figuring out the dependencies instead of say, doing a topologically search and 
using XML configs. But it works. 

-Game States:
See above.

-Command and Control:
It works.

Original comment by LLw...@gmail.com on 29 Dec 2010 at 5:45

GoogleCodeExporter commented 9 years ago

Original comment by LLw...@gmail.com on 29 Dec 2010 at 5:45