search

ColinHDev / CPlot

Land and world management plugin for PocketMine-MP
https://discord.gg/cAYKEtaqnp
GNU General Public License v3.0
29 stars 12 forks source link

Fixed being able to claim over limit if you have merged plots #60

Closed Acsrel closed 2 years ago

Acsrel commented 2 years ago

Say your plot limit is 4, if you claim all 4, you can't claim more, if you merge 2 of the 4, it'll count as 1, making it so you own 3 plots rather than 4, which allows you to claim an extra plot, in this case a 5th plot, this exploit allows players to claim unlimited plots over their plot limit, this pull request fixes it.

ColinHDev commented 2 years ago

Well, you could argue that by merging you essentially have one plot. I think adding a claim.countMergePlots config option would be better, allowing server owners to use their preferred implementation whether merged plots should count towards the limit.

Acsrel commented 2 years ago

Well, you could argue that by merging you essentially have one plot. I think adding a claim.countMergePlots config option would be better, allowing server owners to use their preferred implementation whether merged plots should count towards the limit.

I don't really agree, this would mean if someone had a limit of 2 plots, they could keep on claiming 2 plots, merging them, claim another one, merge, and do that forever allowing them to have huge amount of land, which defeats the purpose of limiting the amount of plots to claim, it could be a configurable option but I doubt anyone would want it to be like that.

ColinHDev commented 2 years ago

Hmm, I was always viewing the merge feature as something you put a fee on with the economy settings. But you are right, if someone allows merging for free on their server, a player is able to get unlimited building space.