Myplot Database Import - Githubissues

ColinHDev / CPlot

Land and world management plugin for PocketMine-MP

https://discord.gg/cAYKEtaqnp

GNU General Public License v3.0

29 stars 12 forks source link

Myplot Database Import #63

Closed jasonw4331 closed 2 years ago

jasonw4331 commented 2 years ago

This PR enables importing the myplot database through the CPlot DataProvider API. In conjunction with world imports, this completes the basic requirements for a smooth transition across plugins.

Currenty there is some data lost in the transfer due to differences in database layout:

Biome (Not stored in CPlot)
Price (Not stored in CPlot)

These may want to be accounted for if the databases ever reach parity.

ColinHDev commented 2 years ago

Thank you really much for your contribution! I will have a detailed look into the PR over the day.

About the data loss: Yes, currently the price would be lost. My plan would have been, to first work on the buy/sell feature before looking into the MyPlot compatibility. About the biome data... I intentionally removed it from the database (9fdd2e39dab95db4c92e3595213fbe3a5a37f8ee) since that data doesn't matter. It's already stored with much more detail (biome info for each xz column) within the world's LevelDB files.

jasonw4331 commented 2 years ago

I think this branch is safe to be merged. PR #17 can be left open

ColinHDev commented 2 years ago

Ahh, alright, I forgot that myplot-support is the target branch. Thank you very much for your contribution!