ColinHDev / CPlot

Land and world management plugin for PocketMine-MP
https://discord.gg/cAYKEtaqnp
GNU General Public License v3.0
29 stars 12 forks source link

MyPlot compatiblity fails if AllowFireTicking is not set in the world config.yml #76

Closed HimbeersaftLP closed 1 year ago

HimbeersaftLP commented 1 year ago

Old configurations of MyPlot don't have this value: https://github.com/ColinHDev/CPlot/blob/a677069f425065f63a555f0afe22c17c4f183c6e/src/ColinHDev/CPlot/provider/DataProvider.php#L1515

Causing the following error:

ErrorException: "Undefined array key "AllowFireTicking"" (EXCEPTION) in "plugins/pharynx-output.phar/src/ColinHDev/CPlot/provider/DataProvider" at line 1515
ColinHDev commented 1 year ago

Thank you really much for your reports. You don't happen to know how MyPlot behaved in that version, to decide the flag's value?

HimbeersaftLP commented 1 year ago

Looks like the default is false: https://github.com/jasonw4331/MyPlot/blob/cc5b2f81817166c89bd62a5761daaf9f480ececf/src/MyPlot/EventListener.php#L71

HimbeersaftLP commented 1 year ago

Thank you!